Skip to content

fix: cpu pegging when shpool attach stdin is null #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ethanpailes merged 1 commit into from
Feb 5, 2026
Merged

fix: cpu pegging when shpool attach stdin is null #306

ethanpailes merged 1 commit into from
Feb 5, 2026

Conversation

@ethanpailes
Copy link
Contributor

@ethanpailes ethanpailes commented Feb 5, 2026

This patch fixes an issue where we would peg the CPU if the stdin to shpool attach was null.

We handle this by immediately exiting the attach proc if stdin is null.

Fixes #243

Replaces #246

@ethanpailes ethanpailes requested a review from maxhbooth February 5, 2026 22:56
@ethanpailes ethanpailes mentioned this pull request Feb 5, 2026
Closed
@maxhbooth
Copy link

maxhbooth commented Feb 5, 2026

looks like there are some cranky errors:

error: length comparison to zero
    --> shpool/tests/attach.rs:1592:12
     |
1592 |         if list_blob["sessions"].as_array().unwrap().len() == 0 {
     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list_blob["sessions"].as_array().unwrap().is_empty()`

@ethanpailes
fix: cpu pegging when shpool attach stdin is null
d8ba4c6 
This patch fixes an issue where we would peg the CPU
if the stdin to `shpool attach` was null.

We handle this by immediately exiting the attach proc
if stdin is null.

Fixes #243

Replaces #246
@ethanpailes ethanpailes force-pushed the fix-CPU-spinning-on-null-stdin branch from 5b9664b to d8ba4c6 Compare February 5, 2026 23:00
@ethanpailes
Copy link
Contributor Author

ethanpailes commented Feb 5, 2026

Yeah, true. Should be fixed now.

@ethanpailes ethanpailes merged commit 6f96063 into master Feb 5, 2026
7 checks passed
@ethanpailes ethanpailes deleted the fix-CPU-spinning-on-null-stdin branch February 5, 2026 23:03
@release-plz-for-shpool release-plz-for-shpool bot mentioned this pull request Feb 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxhbooth maxhbooth maxhbooth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Running shpool in background consumes CPU

2 participants

@ethanpailes @maxhbooth